Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return in addmul! #1541

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix return in addmul! #1541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/arb/arb.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2014,7 +2014,7 @@
function addmul!(z::arb, x::arb, y::ZZRingElem)
q = max(bits(z), bits(x))
ccall((:arb_addmul_fmpz, libarb), Nothing, (Ref{arb}, Ref{arb}, Ref{ZZRingElem}, Int), z, x, y, q)
return nothing
return z

Check warning on line 2017 in src/arb/arb.jl

View check run for this annotation

Codecov / codecov/patch

src/arb/arb.jl#L2017 

Added line #L2017 was not covered by tests
end

################################################################################
Expand Down
4 changes: 2 additions & 2 deletions src/flint/fmpz_mat.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1427,13 +1427,13 @@
function addmul!(z::ZZMatrix, y::ZZMatrix, x::ZZRingElem)
ccall((:fmpz_mat_scalar_addmul_fmpz, libflint), Nothing,
(Ref{ZZMatrix}, Ref{ZZMatrix}, Ref{ZZRingElem}), z, y, x)
return y
return z

Check warning on line 1430 in src/flint/fmpz_mat.jl

View check run for this annotation

Codecov / codecov/patch

src/flint/fmpz_mat.jl#L1430 

Added line #L1430 was not covered by tests
end

function addmul!(z::ZZMatrix, y::ZZMatrix, x::Int)
ccall((:fmpz_mat_scalar_addmul_si, libflint), Nothing,
(Ref{ZZMatrix}, Ref{ZZMatrix}, Int), z, y, x)
return y
return z

Check warning on line 1436 in src/flint/fmpz_mat.jl

View check run for this annotation

Codecov / codecov/patch

src/flint/fmpz_mat.jl#L1436 

Added line #L1436 was not covered by tests
end

function addeq!(z::ZZMatrix, x::ZZMatrix)
Expand Down
Loading