Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复IOS端H5-选中视频-不触发成功/失败回调【3.x】 #16942

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

zhengyanan1
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
IOS端浏览器环境,Taro.chooseMedia,选中视频时,无法触发成功/失败的回调

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

@zhengyanan1 zhengyanan1 changed the title fix: 修复IOS端H5-选中视频-不触发成功/失败回调 fix: 修复IOS端H5-选中视频-不触发成功/失败回调-3.x Nov 29, 2024
@zhengyanan1 zhengyanan1 changed the title fix: 修复IOS端H5-选中视频-不触发成功/失败回调-3.x fix: 修复IOS端H5-选中视频-不触发成功/失败回调【3.x】 Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.45%. Comparing base (fad526a) to head (eaaa4a1).
Report is 3 commits behind head on 3.x.

Files with missing lines Patch % Lines
...ackages/taro-h5/src/api/media/video/chooseMedia.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              3.x   #16942      +/-   ##
==========================================
- Coverage   56.51%   56.45%   -0.06%     
==========================================
  Files         500      500              
  Lines       22765    22801      +36     
  Branches     5652     5666      +14     
==========================================
+ Hits        12866    12873       +7     
- Misses       8693     8718      +25     
- Partials     1206     1210       +4     
Flag Coverage Δ
taro-cli 75.00% <ø> (+25.78%) ⬆️
taro-runner 54.01% <ø> (ø)
taro-runtime 76.08% <ø> (-3.32%) ⬇️
taro-web 40.47% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ackages/taro-h5/src/api/media/video/chooseMedia.ts 1.58% <0.00%> (+1.58%) ⬆️

... and 1 file with indirect coverage changes

@tutuxxx tutuxxx self-requested a review November 29, 2024 09:34
@tutuxxx tutuxxx merged commit dd987d8 into 3.x Nov 29, 2024
25 of 26 checks passed
@tutuxxx tutuxxx deleted the fix/3.x-oncanplay branch November 29, 2024 09:35
This was referenced Nov 30, 2024
@zhengyanan1 zhengyanan1 restored the fix/3.x-oncanplay branch December 2, 2024 06:39
zhengyanan1 added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants