Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复IOS端H5-选中视频-不触发成功/失败回调【3.x】 #16942

Merged
merged 1 commit into from
Nov 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/taro-h5/src/api/media/video/chooseMedia.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Taro from '@tarojs/api'
import { isMobile } from 'is-mobile'

import { getDeviceInfo } from '../../../api/base/system'
import { showActionSheet } from '../../../api/ui'
import { getParameterError, shouldBeObject } from '../../../utils'
import { MethodHandler } from '../../../utils/handler'
Expand Down Expand Up @@ -136,6 +137,7 @@

if (/^video\//.test(res.fileType)) {
// Video
const isIOS = getDeviceInfo().system.toLowerCase().includes('ios')

Check warning on line 140 in packages/taro-h5/src/api/media/video/chooseMedia.ts

View check run for this annotation

Codecov / codecov/patch

packages/taro-h5/src/api/media/video/chooseMedia.ts#L140

Added line #L140 was not covered by tests
const video = document.createElement('video')
const reader = new FileReader()
video.crossOrigin = 'Anonymous'
Expand All @@ -160,6 +162,7 @@
resolve(res)
}
video.onerror = e => reject(e)
isIOS && video.load()
})
} else {
// Image
Expand Down
Loading