Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored code to remove codeSmells #601

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

shah-utkarsh
Copy link

In this pull request, I have refactored the code to increase the maintainability, readability and to remove some Implementation smells and design smells.

Set 1:

  • Rename variable
  • Decompose Conditional
  • Introduced explaining variable

Set 2:

  • Move method
  • Extract Class
  • Replace conditional with polymorphism
  • Push down method

UTKARSH SHAH added 9 commits April 4, 2023 14:58
…aPlan to updatePlan to increase code readability
…axDestinationVersion variable to reduce one if statement (snapshotDestinationVersion == deltaDestinationVersion)
…neratorConfig.java as it was using all the parameters of CodeGeneratorConfig class
…PI.java using Extract Class technique and created a class called SampleResultsRetrival
…UpdatePlanner.java to disolve a complex condition by introducing a new variable in planUpdate() method
@shah-utkarsh shah-utkarsh changed the title Refractor codesmells Refactor code smells as a Part of assignment at Dalhousie University Apr 6, 2023
@shah-utkarsh shah-utkarsh changed the title Refactor code smells as a Part of assignment at Dalhousie University Refactored code to remove codeSmells. Apr 6, 2023
@shah-utkarsh shah-utkarsh changed the title Refactored code to remove codeSmells. Refactored code to remove codeSmells Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant