Code

Refactored code to remove codeSmells#601

Code

Open

shah-utkarsh wants to merge 9 commits intoNetflix:masterNetflix/hollow:masterfrom shah-utkarsh:refractor-codesmellsshah-utkarsh/hollow:refractor-codesmellsCopy head branch name to clipboard

+291-70

Commits

Commits on Apr 4, 2023

• Refractored: hollow/api/client/HollowUpdatePlanner.java to Remove complex conditonal code smell

  

  UTKARSH SHAH

  committed
  c843e8b

• Refractored: hollow/api/client/HollowUpdatePlanner.java, Renamed deltaPlan to updatePlan to increase code readability

  

  UTKARSH SHAH

  committed
  2a6acd2

• Refractored: hollow/api/client/HollowUpdatePlanner.java, Introduced maxDestinationVersion variable to reduce one if statement (snapshotDestinationVersion == deltaDestinationVersion)

  

  UTKARSH SHAH

  committed
  2f7c4a5

Commits on Apr 6, 2023

• Moved the method from HollowConsumerJavaFileGeneration.java to CodeGeneratorConfig.java as it was using all the parameters of CodeGeneratorConfig class

  

  UTKARSH SHAH

  committed
  08a34f3

• Refactored : Replaced Conditional with Polymorphism technique

  

  UTKARSH SHAH

  committed
  0ff3057

• Refactored hollow/src/main/java/com/netflix/hollow/api/custom/HollowAPI.java using Extract Class technique and created a class called SampleResultsRetrival

  

  UTKARSH SHAH

  committed
  65f958f

• Changes reverted in HollowUpdatePlanner.java

  

  UTKARSH SHAH

  committed
  19e66f5

• Renamed variable refactoring applied. Renamed deltaPlan to udpatedPlan to increase readability of the code.

  

  UTKARSH SHAH

  committed
  641517e

• Refactored: hollow/src/main/java/com/netflix/hollow/api/client/HollowUpdatePlanner.java to disolve a complex condition by introducing a new variable in planUpdate() method

  

  UTKARSH SHAH

  committed
  e7c008b