Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kiota API to 26.0.5 #154

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Conversation

Persistent13
Copy link
Contributor

@Persistent13 Persistent13 commented Nov 10, 2024

closes: #148

@Persistent13
Copy link
Contributor Author

I'm going to update the out-of-date action bits to the latest and see what, if anything, breaks.

@Persistent13
Copy link
Contributor Author

image

Nice!

@NikiforovAll Let me know if there's anything disagreeable in this PR and I'll do my best to correct.

@NikiforovAll
Copy link
Owner

@Persistent13 Could you please update the version of the Kitoa package manually?

@NikiforovAll
Copy link
Owner

Also, kiota CLI has been installed as dotnet-tool, could you please update id and try to regenerate to make sure we use the same version of Kiota CLI

@NikiforovAll
Copy link
Owner

Also, please make changes from #148 to this PR

@NikiforovAll
Copy link
Owner

First and foremost, thank you for the contribution

@Persistent13
Copy link
Contributor Author

@NikiforovAll I've updated the kiota versions and re-ran the generation command. I used 1.14.0 as that was newer, if you'd like me to use 1.13.1 explicitly, please let me know.

I updated the nuget package version to 26.0.5.

Please let me know if there's anything else.

@NikiforovAll
Copy link
Owner

Thank you for your contribution. Did you run dotnet tool restore in the root of the directory? I think we have kiota 1.15 installed as a local dotnet tool. Could you please update the version of the local dotnet tool and re-run the generation?

dotnet tool install --local Microsoft.OpenApi.Kiota --version 1.20.0

Also, it would be great to test the generated SDK manually to make sure everything works. What do you think?

@Persistent13
Copy link
Contributor Author

Yes, I did run it with the cached version. Apologies!

I think the new push should have corrected this. I won't be able to test it my time tonight, but I should be able to tomorrow. I'll update with my findings then.

@NikiforovAll
Copy link
Owner

I appreciate your work!

@Persistent13
Copy link
Contributor Author

@NikiforovAll Sorry for the delay, I had some stuff that took my time away from this.

From what I can see, it all works fine. I tried out the newer organization APIs as well and didn't run into any issues. I could create and delete orgs without issue after enabling the feature for a given realm.

@NikiforovAll NikiforovAll merged commit 6075dc3 into NikiforovAll:main Nov 21, 2024
8 checks passed
@Persistent13 Persistent13 deleted the 26.0.5 branch November 22, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants