-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][IMP] delivery_cttexpress: configurable label delay #735
Merged
OCA-git-bot
merged 1 commit into
OCA:12.0
from
Tecnativa:12.0-fix-delivery_cttexpress-shipping-label
Dec 12, 2023
Merged
[12.0][IMP] delivery_cttexpress: configurable label delay #735
OCA-git-bot
merged 1 commit into
OCA:12.0
from
Tecnativa:12.0-fix-delivery_cttexpress-shipping-label
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
approved these changes
Dec 11, 2023
pedrobaeza
reviewed
Dec 11, 2023
pedrobaeza
reviewed
Dec 11, 2023
chienandalu
force-pushed
the
12.0-fix-delivery_cttexpress-shipping-label
branch
from
December 12, 2023 07:54
682c0da
to
4e51149
Compare
Suggestions done 👍 |
victoralmau
approved these changes
Dec 12, 2023
When we recod a shipping in the CTT Express backend the label API could not be ready in the moment to retrieve the labels. As CTT Express stated, a little delay would add the needed time for the API to be ready. TT46443
chienandalu
force-pushed
the
12.0-fix-delivery_cttexpress-shipping-label
branch
from
December 12, 2023 08:13
4e51149
to
e7c6629
Compare
pedrobaeza
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge minor
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at cc3aaec. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we recod a shipping in the CTT Express backend the label API could not be ready in the moment to retrieve the labels. As CTT Express stated, a little delay would add the needed time for the API to be ready.
cc @Tecnativa TT46443
ping @pedrobaeza @victoralmau