[17.0][MIG] helpdesk_mgmt_fieldservice #652
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to open a res_partner form with a user who doesn't have permission for read fieldservice data, this view causes an error cause it try to set attributes to a button that doesn't exist. Specifying groups_id fix this, extending the view only if the current user has permissions to see that button.
Currently translated at 100.0% (32 of 32 strings) Translation: helpdesk-12.0/helpdesk-12.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-12-0/helpdesk-12-0-helpdesk_mgmt_fieldservice/fr/
Currently translated at 100.0% (36 of 36 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_fieldservice/it/
Currently translated at 100.0% (36 of 36 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_fieldservice/es/
Currently translated at 100.0% (36 of 36 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_fieldservice Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_fieldservice/pt_BR/
imlopes
force-pushed
the
17.0-mig-helpdesk_mgmt_fieldservice
branch
2 times, most recently
from
d20e4a8
to
1696b79
Compare
imlopes
force-pushed
the
17.0-mig-helpdesk_mgmt_fieldservice
branch
from
1696b79
to
59caa0c
Compare
yankinmax
reviewed
Nov 12, 2024
| @@ -10,10 +10,10 @@ def action_view_helpdesk_tickets(self): | |||
| ) and self.env.user.has_group("helpdesk_mgmt.group_helpdesk_user_own"): | |||
| context = dict(self.env.context) | |||
| context.pop("search_default_open", None) | |||
| self = self.with_context( | |||
| context_self = self.with_context( | |||
There was a problem hiding this comment.
This change is useless. I would instead just clean the super call as self will be updated with context anyway:
return super().action_view_helpdesk_tickets()
So we need only one return statement in the end
yankinmax
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this PR: #608