[FIX] l10n_nl_kvk: adapt tsts to changed demo data #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbrunn
force-pushed
the
12.0-l10n_nl_kvk-fix_tests
branch
from
7acc3bf
to
2711155
Compare
thomaspaulb
approved these changes
Mar 19, 2024
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 7848b0c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turns out the tests call KVK's test environment, and the test environment has changed the values being returned slightly.
Verify with
Now the right thing to do would be to mock.patch away those calls of course, but as of https://developers.kvk.nl/nl/documentation/testing the v1 api this addon uses will be retired by July 29th, so I'd find it a little bit pointless to do so now. By that date we should deactivate this addon anyways if nobody ports it to the v2 api meanwhile.