[14.0][MIG] product_expiry_simple #tryagain

[bealdav]

supersed #934

[rousseldenis]

/ocabot migration product_expiry_simple

[bealdav]

Please @rousseldenis could you help to fix configuration to get it works
by comparison of https://github.com/OCA/server-tools/blob/14.0/.github/workflows/test.yml#L36
it seems ok, but in real not

[rousseldenis]

Yes, I saw your tries.

But, the problem here I think is the mutual exclusion in the manifest. I think the product_expiry module is installed in the first step as required by other modules.

I think you should exclude them also and put in the rebel modules: stock_mass_scrap, stock_move_quick_lot. Could you try ?

@sbidoul Any advice?

[sbidoul]

Looking at the error I see "product_expiration_date does not exist". But indeed this module does not exist in this repo?

[bealdav]

You're right, madre mia, I shouldn't work after 22h, caramba !

[OCA-git-bot]

The migration issue (#708) has been updated to reference the current pull request.
however, a previous pull request was referenced : #934.
Perhaps you should check that there is no duplicate work.
CC : @alexis-via

[rousseldenis]

And @bealdav the question at 10.000 dollars. Isn't there a mean to make this (the module) configurable to allow it being installed along with product_expiry ?

[bealdav]

@rousseldenis I suppose you suggest a new module product_expiry_simple_but_not_so_easy_finally ?

[rousseldenis]

@rousseldenis I suppose you suggest a new module product_expiry_simple_but_nor_so_easy_finally ?

No, I wanted to see if both can coexist. Maybe by hiding the standard fields when installing this

[bealdav]

Yes, I understood, sorry for my joke ;-)
I think @alexis-via might be opposite to this option ?

But you're right, in this case runboat fails because of raise UserError(msg % (module.shortdesc, exclusion.exclusion_id.shortdesc)) odoo.exceptions.UserError: Modules "Product Expiry Simple" and "Products Expiration Date" are incompatible.

[bealdav]

What are the options to make runboat works even if product_expiry_simple is not installed ?

[rousseldenis]

What are the options to make runboat works even if product_expiry_simple is not installed ?

I think this is not possible as exclude key in manifest raises an Exception:

Maybe to have its own repo should be a solution

[sbidoul]

What are the options to make runboat works even if product_expiry_simple is not installed ?

At the moment, runboat does not support conflicting modules that prevent simultaneous installation of all modules in the repo. Suggestions are welcome in sbidoul/runboat#36

[bealdav]

Probably, but runboat install addons of the whole repo with dependency.
Could we consider runboat install the whole repo except rebels ones ?

[alexis-via]

I don't believe in a solution where product_expiry_simple depend on product_expiry ; I think it will bring more problems than solutions. The goal of product_expiry_simple is to have a easier/simpler drop-in replacement to product_expiry. Then we need to adapt the OCA tests system to allow the development of such alternative modules.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[bealdav]

@sbidoul @rousseldenis could you add no stale label to this PR. Thanks.

[rousseldenis]

@bealdav Following sbidoul/runboat#36, is this needing the rebel module configuration ?

[bealdav]

I suppose this not needed, then we can merge this PR as soon as there reviews. Could you approve the PR @rousseldenis ?

[florian-dacosta]

LGTM

[bguillot]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1271-by-bguillot-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at c52c818. Thanks a lot for contributing to OCA. ❤️

[francesco-ooops]

@bguillot @bealdav @rousseldenis this has broken runboat for other PRs, eg: #1383

[bealdav]

Oops, I forgot sbidoul/runboat#36 to deal with rebel modules.

[rousseldenis]

Oops, I forgot sbidoul/runboat#36 to deal with rebel modules.

Yes. This will prevent testing on runboat but not merges. We will need to manage it during OCA days. Remotely :-(

[francesco-ooops]

@rousseldenis any plan to fix runboat for 14? thank you!

[francesco-ooops]

@bealdav gentle reminder as we're out of runboat on v14 :)

[bealdav]

The problem is that I don't really understand runboat machinery to make a pertinent PR. ;-(
Really sorry

[rousseldenis]

@bealdav Solved. Read https://github.com/orgs/OCA/discussions/126#discussioncomment-7624191