-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG] product_expiry_simple #tryagain #1271
Merged
OCA-git-bot
merged 21 commits into
OCA:14.0
from
akretion:14-mig-product_expiry_simple-again
Oct 12, 2023
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ad176dd
Add module product_expiry_simple
alexis-via 8bb8071
Small search view organisation improvement
alexis-via 707ccd6
OCA coding standards
alexis-via 9c0099b
Finish port of FEFO code to v10
alexis-via 57ddbfa
Add FR translation for product_expiry_simple
alexis-via 4346d37
Improve module description in README
alexis-via f7774dd
OCA Transbot updated translations from Transifex
oca-transbot 7f1d9ce
make changes to migrate module to V11
alan196 bd24a5f
Update product_expiry_simple.pot
oca-travis 45d5724
product_expiry_simple: delete duplicate view
enriquemartin 94d7256
icon.png
OCA-git-bot 9283686
[MIG] product_expiry_simple from v11 to v12
alexis-via c08369f
Fix bug when both use_create_lots and use_existing_lots are enabled o…
alexis-via 919c576
FIX product_expiry_simple: key in manifest
bealdav d82893c
product_expiry_simple: add myself as maintainer
alexis-via 7059ef1
Upport fix for bug #548 to v12
alexis-via 9516b9a
[MIG] product_expiry_simple from v12 to v14
alexis-via 50a3a5d
product_expiry_simple: black, isort, etc...
alexis-via a162dca
product_expiry_simple: use format_date to show date in lot display_name
alexis-via 4da9160
product_expiry_simple: add warning banner on picking
alexis-via 51ee61c
FIX product_expiry_simple: pre-commit & copier stuff
bealdav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg | ||
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
:alt: License: AGPL-3 | ||
|
||
===================== | ||
Product Expiry Simple | ||
===================== | ||
|
||
This module is similar to the official `product_expiry <https://www.odoo.com/apps/modules/11.0/product_expiry/>`_ module that adds support for *Expiry Dates* on products, but it is both simpler and better: | ||
|
||
* Only one *Expiry Date* field instead of 4 fields (End of Life Date, Best before Date, Removal Date, Alert Date)! | ||
* Use date field instead of datetime field for *Expiry Date* | ||
* No automatic computing of Expiry Date based on a delay configured on product because it is not used most of the time (for manufacturing companies, the rules that control expiry dates are usually more complex than that ; for reseller companies, they have to copy the expiry date written on the good when they receive it in their warehouse) | ||
* List views of production lots and quants have a color depending on expiry date: green if expiry date is in the future, red if it is in the past. | ||
* Ability to show stats about expiry dates on quants pivot table (because, with this module, the *Expiry Date* is a related stored field on stock.quant). | ||
|
||
This modules keeps the main feature of the official *product_expiry* module: the support of FEFO (First Expiry First Out). | ||
|
||
I decided to develop this module because, after implementing *product_expiry* at several companies, I noticed that I spent more time inheriting the official *product_expiry* module to make always the same kind of changes that re-developping a simpler and better alternative. | ||
|
||
Configuration | ||
============= | ||
|
||
No configuration needed. | ||
|
||
Usage | ||
===== | ||
|
||
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
:alt: Try me on Runbot | ||
:target: https://runbot.odoo-community.org/runbot/154/11.0 | ||
|
||
Bug Tracker | ||
=========== | ||
|
||
Bugs are tracked on `GitHub Issues | ||
<https://github.com/OCA/stock-logistics-workflow/issues>`_. In case of trouble, please | ||
check there if your issue has already been reported. If you spotted it first, | ||
help us smashing it by providing a detailed and welcomed feedback. | ||
|
||
Credits | ||
======= | ||
|
||
Contributors | ||
------------ | ||
|
||
* Alexis de Lattre <[email protected]> | ||
* Alan Ramos <[email protected]> | ||
|
||
Maintainer | ||
---------- | ||
|
||
.. image:: https://odoo-community.org/logo.png | ||
:alt: Odoo Community Association | ||
:target: https://odoo-community.org | ||
|
||
This module is maintained by the OCA. | ||
|
||
OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
mission is to support the collaborative development of Odoo features and | ||
promote its widespread use. | ||
|
||
To contribute to this module, please visit https://odoo-community.org. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
from . import models |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Copyright 2017-2021 Akretion France (http://www.akretion.com/) | ||
# Copyright 2018-2021 Jarsa Sistemas (Alan Ramos <[email protected]>) | ||
# @author: Alexis de Lattre <[email protected]> | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
||
{ | ||
"name": "Product Expiry Simple", | ||
"version": "14.0.1.0.0", | ||
"category": "Product", | ||
"license": "AGPL-3", | ||
"summary": "Simpler and better alternative to the official product_expiry module", | ||
"author": "Akretion,Jarsa Sistemas,Odoo Community Association (OCA)", | ||
"maintainers": ["alexis-via"], | ||
"website": "https://github.com/OCA/stock-logistics-workflow", | ||
"depends": [ | ||
"stock", | ||
], | ||
"excludes": ["product_expiry"], | ||
"data": [ | ||
"data/product_removal.xml", | ||
"views/stock_production_lot.xml", | ||
"views/stock_quant.xml", | ||
"views/stock_move_line.xml", | ||
"views/stock_picking.xml", | ||
], | ||
"installable": True, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<?xml version="1.0" ?> | ||
<odoo> | ||
<record id="removal_fefo" model="product.removal"> | ||
<field name="name">First Expiry First Out (FEFO)</field> | ||
<field name="method">fefo</field> | ||
</record> | ||
</odoo> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# Translation of Odoo Server. | ||
# This file contains the translation of the following modules: | ||
# * product_expiry_simple | ||
# | ||
# Translators: | ||
# OCA Transbot <[email protected]>, 2017 | ||
msgid "" | ||
msgstr "" | ||
"Project-Id-Version: Odoo Server 10.0\n" | ||
"Report-Msgid-Bugs-To: \n" | ||
"POT-Creation-Date: 2017-12-03 03:55+0000\n" | ||
"PO-Revision-Date: 2017-12-03 03:55+0000\n" | ||
"Last-Translator: OCA Transbot <[email protected]>, 2017\n" | ||
"Language-Team: German (https://www.transifex.com/oca/teams/23907/de/)\n" | ||
"Language: de\n" | ||
"MIME-Version: 1.0\n" | ||
"Content-Type: text/plain; charset=UTF-8\n" | ||
"Content-Transfer-Encoding: \n" | ||
"Plural-Forms: nplurals=2; plural=(n != 1);\n" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Expired" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_move_line_expiry_date | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_production_lot_expiry_date | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_quant_expiry_date | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Expiry Date" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_production_lot | ||
msgid "Lot/Serial" | ||
msgstr "Los/Serie" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Not Expired" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_move_line | ||
msgid "Packing Operation" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_quant | ||
msgid "Quants" | ||
msgstr "" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
# Translation of Odoo Server. | ||
# This file contains the translation of the following modules: | ||
# * product_expiry_simple | ||
# | ||
msgid "" | ||
msgstr "" | ||
"Project-Id-Version: Odoo Server 11.0+e\n" | ||
"Report-Msgid-Bugs-To: \n" | ||
"POT-Creation-Date: 2018-01-05 02:21+0000\n" | ||
"PO-Revision-Date: 2018-01-05 02:21+0000\n" | ||
"Last-Translator: <>\n" | ||
"Language-Team: \n" | ||
"Language: \n" | ||
"MIME-Version: 1.0\n" | ||
"Content-Type: text/plain; charset=UTF-8\n" | ||
"Content-Transfer-Encoding: \n" | ||
"Plural-Forms: \n" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Expired" | ||
msgstr "Expirado" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_move_line_expiry_date | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_production_lot_expiry_date | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_quant_expiry_date | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Expiry Date" | ||
msgstr "Fecha de Expiración" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_production_lot | ||
msgid "Lot/Serial" | ||
msgstr "Lote/Nº de serie" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Not Expired" | ||
msgstr "No Expirado" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_move_line | ||
msgid "Packing Operation" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_quant | ||
msgid "Quants" | ||
msgstr "Quants" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# Translation of Odoo Server. | ||
# This file contains the translation of the following modules: | ||
# * product_expiry_simple | ||
# | ||
# Translators: | ||
# OCA Transbot <[email protected]>, 2017 | ||
msgid "" | ||
msgstr "" | ||
"Project-Id-Version: Odoo Server 10.0\n" | ||
"Report-Msgid-Bugs-To: \n" | ||
"POT-Creation-Date: 2017-12-03 03:55+0000\n" | ||
"PO-Revision-Date: 2017-12-03 03:55+0000\n" | ||
"Last-Translator: OCA Transbot <[email protected]>, 2017\n" | ||
"Language-Team: Italian (https://www.transifex.com/oca/teams/23907/it/)\n" | ||
"Language: it\n" | ||
"MIME-Version: 1.0\n" | ||
"Content-Type: text/plain; charset=UTF-8\n" | ||
"Content-Transfer-Encoding: \n" | ||
"Plural-Forms: nplurals=2; plural=(n != 1);\n" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Expired" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_move_line_expiry_date | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_production_lot_expiry_date | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_quant_expiry_date | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Expiry Date" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_production_lot | ||
msgid "Lot/Serial" | ||
msgstr "Lotto/Numero di serie" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Not Expired" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_move_line | ||
msgid "Packing Operation" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_quant | ||
msgid "Quants" | ||
msgstr "" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# Translation of Odoo Server. | ||
# This file contains the translation of the following modules: | ||
# * product_expiry_simple | ||
# | ||
# Translators: | ||
# Peter Hageman <[email protected]>, 2017 | ||
msgid "" | ||
msgstr "" | ||
"Project-Id-Version: Odoo Server 10.0\n" | ||
"Report-Msgid-Bugs-To: \n" | ||
"POT-Creation-Date: 2017-06-17 01:29+0000\n" | ||
"PO-Revision-Date: 2017-06-17 01:29+0000\n" | ||
"Last-Translator: Peter Hageman <[email protected]>, 2017\n" | ||
"Language-Team: Dutch (Netherlands) (https://www.transifex.com/oca/" | ||
"teams/23907/nl_NL/)\n" | ||
"Language: nl_NL\n" | ||
"MIME-Version: 1.0\n" | ||
"Content-Type: text/plain; charset=UTF-8\n" | ||
"Content-Transfer-Encoding: \n" | ||
"Plural-Forms: nplurals=2; plural=(n != 1);\n" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Expired" | ||
msgstr "Vervallen" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_move_line_expiry_date | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_production_lot_expiry_date | ||
#: model:ir.model.fields,field_description:product_expiry_simple.field_stock_quant_expiry_date | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Expiry Date" | ||
msgstr "Vervaldatum" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_production_lot | ||
msgid "Lot/Serial" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.quant_search_view | ||
#: model:ir.ui.view,arch_db:product_expiry_simple.search_product_lot_filter | ||
msgid "Not Expired" | ||
msgstr "Niet Vervallen" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_move_line | ||
msgid "Packing Operation" | ||
msgstr "" | ||
|
||
#. module: product_expiry_simple | ||
#: model:ir.model,name:product_expiry_simple.model_stock_quant | ||
msgid "Quants" | ||
msgstr "" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please @rousseldenis could you help to fix configuration to get it works
by comparison of https://github.com/OCA/server-tools/blob/14.0/.github/workflows/test.yml#L36
it seems ok, but in real not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I saw your tries.
But, the problem here I think is the mutual exclusion in the manifest. I think the product_expiry module is installed in the first step as required by other modules.
I think you should exclude them also and put in the rebel modules: stock_mass_scrap, stock_move_quick_lot. Could you try ?
@sbidoul Any advice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the error I see "product_expiration_date does not exist". But indeed this module does not exist in this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, madre mia, I shouldn't work after 22h, caramba !