Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] stock_move_planned_consumed_date #1508

Closed

Conversation

petrus-v
Copy link
Contributor

@petrus-v petrus-v commented Feb 19, 2024

Base module to avoid mixing move line that is planned to consumed in different dates

@petrus-v petrus-v force-pushed the 14.0-add-stock_move_planned_consumed_date branch from 30ab4a8 to fad7f75 Compare February 20, 2024 11:03
@petrus-v petrus-v changed the title [ADD] stock_move_planned_consumed_date: base module to avoid mixing m… [ADD] stock_move_planned_consumed_date Feb 20, 2024
@rousseldenis
Copy link
Contributor

@petrus-v Have you tried with date_deadline field ?

@rousseldenis
Copy link
Contributor

@petrus-v Have you tried with date_deadline field ?

Which is propagated at sale order confirmation from the commitment_date on the order level

@petrus-v
Copy link
Contributor Author

petrus-v commented Feb 20, 2024

@petrus-v Have you tried with date_deadline field ?

I know about the date_deadline which propagate on stock_picking, but if you check the availability of those picking a bit earlier nothing prevent to reserved products that will be expired before the deadline (At the moment we haven't installed stock release modules mechanisms), also in complex industry with multiple warehouse where procurement group are not necessarily propagated we could get some transfer (stock.picking) with different moves where expected consumed date are different (to make this easier to reproduce we are using #1226 which basically round the deadline date time to date)

this is the base module for #1509 and #1511

@rousseldenis
Copy link
Contributor

rousseldenis commented Feb 20, 2024

@petrus-v Have you tried with date_deadline field ?

I know about the date_deadline which propagate on stock_picking, but if you check the availability of those picking a bit earlier nothing prevent to reserved products that will be expired before the deadline (At the moment we haven't installed stock release modules mechanisms), also in complex industry with multiple warehouse where procurement group are not necessarily propagated we could get some transfer (stock.picking) with different moves where expected consumed date are different (to make this easier to reproduce we are using #1226 which basically round the deadline date time to date)

this is the base module for #1509 and #1511

Ok, understand.

FYI, there is a change in v16 (and v15) merged yesterday that allows to ignore date_deadline when merging: odoo/odoo@fdaba15

Copy link

@alexandregaldeano alexandregaldeano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are about code style preference, as such, you can of course discard them :)

stock_move_planned_consumed_date/readme/CONTRIBUTIRS.rst Outdated Show resolved Hide resolved
stock_move_planned_consumed_date/models/stock_move.py Outdated Show resolved Hide resolved
stock_move_planned_consumed_date/models/stock_move.py Outdated Show resolved Hide resolved
stock_move_planned_consumed_date/models/stock_rule.py Outdated Show resolved Hide resolved
@petrus-v petrus-v force-pushed the 14.0-add-stock_move_planned_consumed_date branch from fad7f75 to 3788b5a Compare February 20, 2024 21:00
…ove line that is planned to consumed in different dates
@petrus-v petrus-v force-pushed the 14.0-add-stock_move_planned_consumed_date branch from 3788b5a to 9ac87ad Compare February 20, 2024 21:09
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024
@github-actions github-actions bot closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants