[14.0][ADD] stock_restrict_by_planned_consumed_date #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrus-v
force-pushed
the
14.0-add-stock_restrict_by_planned_consumed_date
branch
from
d6c0428
to
d4ddd3e
Compare
This was referenced Feb 20, 2024
petrus-v
changed the title
petrus-v
changed the title
petrus-v
force-pushed
the
14.0-add-stock_restrict_by_planned_consumed_date
branch
from
d4ddd3e
to
b5eeb51
Compare
alexandregaldeano
approved these changes
Feb 22, 2024
Comment on lines
18
to
19
| or quant.lot_id | ||
| and quant.lot_id.expiration_date > planned |
There was a problem hiding this comment.
suggestion,nitpick: Maybe add parenthesis to clearly separate the or and the and?
petrus-v
force-pushed
the
14.0-add-stock_restrict_by_planned_consumed_date
branch
from
b5eeb51
to
11fe34b
Compare
petrus-v
force-pushed
the
14.0-add-stock_restrict_by_planned_consumed_date
branch
from
11fe34b
to
8f87ddb
Compare
Co-authored-by: Alexandre Galdeano <[email protected]>
sebalix
reviewed
Sep 30, 2024
Comment on lines
+17
to
+18
| or quant.lot_id | ||
| and quant.lot_id.expiration_date >= planned |
There was a problem hiding this comment.
Suggested change
| or quant.lot_id | |
| and quant.lot_id.expiration_date >= planned | |
| or ( | |
| quant.lot_id | |
| and quant.lot_id.expiration_date >= planned | |
| ) |
Comment on lines
+1
to
+2
| This module avoid to reserve goods if the planned consumed date by | ||
| the customer is after expiration time. |
There was a problem hiding this comment.
Suggested change
| This module avoid to reserve goods if the planned consumed date by | |
| the customer is after expiration time. | |
| This module avoids to reserve goods having an expiration time prior to the customer's planned consumed date. |
Comment on lines
+1
to
+3
| * Today we restrict expiration lot date must be greater thant planned consumed date in | ||
| some circumstance we probably want something flexible based on product configuration and | ||
| probably based on use_date (best before). |
There was a problem hiding this comment.
Suggested change
| * Today we restrict expiration lot date must be greater thant planned consumed date in | |
| some circumstance we probably want something flexible based on product configuration and | |
| probably based on use_date (best before). | |
| * Today we restrict the reservation based on the lot expiration date, but in | |
| some circumstances we probably want something configurable to base the restriction on `use_date` (best before). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1724 to avoid product reservation if expiration lot is before the expected consumed date