[12.0][MIG] website_portal_contact #882

SirTakobi · 2022-03-21T14:40:12Z

Superseding #840

Added history with format patch, plus some improvement (see commits) that ideally should go in the migration commit.
I'm keeping the new edits in dedicated commits in order to preserve authorship in existing commits.

oca-clabot · 2022-03-21T14:40:14Z

Hey @SirTakobi, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Jairo Llopis [email protected] (no github login found)
Mathieu Benoit [email protected] (no github login found)

Appreciation of efforts,
OCA CLAbot

…CA#239) [ADD] website_portal_contact Manage your contacts from your portal This module extends the functionality of the website portal to allow your users to manage their contacts. To use this module, you need to: 1. Log in as a portal user. 2. Go to your portal home. 3. Go to your contacts manager. 4. Read, create, edit or delete (disable) any contacts you want! Known issues / Roadmap: - This uses the backported version of the website portal from v10. When migrating to v10, we should adapt to any changes there. - Remove workarounds for odoo/odoo#12961 in JS tour when fixed.

- Replace website_portal_v10 by portal - Fix menu, breadcumb and contact_count - Adapt test with tour - Translate fr_CA.po, fr.po and pot - Fix parent_id with the same partner_id

The previous access rules did only allow edits on partners with type == contact. That caused an access error when one edited a contact with another type e.g. "invoice address". This is prevented now by allowing to edit any contact type.

SirTakobi · 2022-03-21T15:11:21Z

Hey @SirTakobi, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla Here is a list of the users:

Jairo Llopis [email protected] (no github login found)

Mathieu Benoit [email protected] (no github login found)

Appreciation of efforts, OCA CLAbot

@yajo @mathben can I have the email linked to your accounts so that I can set it inside your commits?
Otherwise just point me to one of your commits where the github user is recognized and I'll get the email from there.
Thanks!

mathben · 2022-03-21T16:08:33Z

@SirTakobi I update my github settings with the email [email protected]
Is it working?
Thanks

SirTakobi · 2022-03-21T16:28:05Z

@SirTakobi I update my github settings with the email [email protected] Is it working? Thanks

Yes, now your commits in this PR show the github user too:

yajo · 2022-03-22T07:38:00Z

I think that's a bug in the bot and we can just ignore it. See OCA/oca-github-bot#209.

eLBati

eLBati

thanks

tarteo

I tried to install it on my local machine but I get this error:

Exception: Module loading website_portal_contact failed: file website_portal_contact/security/ir.model.access.csv could not be processed:
 No matching record found for external id 'product.model_product_pricelist' in field 'Object'
Missing required value for the field 'Object' (model_id)

I guess a dependency is missing

SirTakobi · 2022-04-01T13:50:55Z

I tried to install it on my local machine but I get this error:

Exception: Module loading website_portal_contact failed: file website_portal_contact/security/ir.model.access.csv could not be processed:
 No matching record found for external id 'product.model_product_pricelist' in field 'Object'
Missing required value for the field 'Object' (model_id)

I guess a dependency is missing

Thanks for having a look, you are right it was missing the dependency from product, now I have added it.

EDIT: I know the new dependency might not fit in this module that ideally should only depend on website and portal, another possible way to fix it would be to create a bridge module for product and website_portal_contact

eLBati

LGTM

tarteo

Thanks!

OCA-git-bot · 2022-04-07T16:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mrcast

Functional test ok!

tarteo · 2022-04-08T11:47:15Z

/ocabot merge nobump

OCA-git-bot · 2022-04-08T11:47:31Z

Sorry @tarteo you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

SirTakobi · 2022-04-08T12:13:26Z

/ocabot merge nobump

@tarteo thanks for trying 😄

Maybe someone of @OCA/website-maintainers can have a look?

SirTakobi · 2022-05-04T07:41:41Z

@OCA/website-maintainers can someone have a look? Thanks!

hbrunn · 2022-05-04T07:44:39Z

could you squash all your migration commits?

[FIX] Prevent error 500 due to missing field 'name' [FIX] Allow to create partners: reading pricelists is needed for computing the pricelist for the created partner. The added rule is similar to product.access_product_pricelist_user. [I18N] Italian translations [REF] New README format [REF] Align UX to other portal pages

… or update

SirTakobi · 2022-05-04T08:43:45Z

could you squash all your migration commits?

I have squashed most of the commits; I have kept a few commits separated because they are dedicated to specific improvements, could you please check if it looks better now?

hbrunn · 2022-05-04T08:58:38Z

thanks
/ocabot merge nobump

OCA-git-bot · 2022-05-04T08:58:44Z

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-882-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot · 2022-05-04T10:10:33Z

Congratulations, your PR was merged at 84e8cfa. Thanks a lot for contributing to OCA. ❤️

SirTakobi force-pushed the 12.0-mig-website_portal_contact branch from 0ee9726 to 305dacb Compare March 21, 2022 14:40

yajo and others added 7 commits March 21, 2022 15:45

OCA Transbot updated translations from Transifex

80766d5

[MIG] Make modules uninstallable

d5782df

[MIG] Rename manifest files

b25b178

[MIG] website_portal_contact: Migration to 12.0

1b2e20d

[MIG] website_portal_contact

adf8af9

- Replace website_portal_v10 by portal - Fix menu, breadcumb and contact_count - Adapt test with tour - Translate fr_CA.po, fr.po and pot - Fix parent_id with the same partner_id

SirTakobi force-pushed the 12.0-mig-website_portal_contact branch from 305dacb to a581160 Compare March 21, 2022 15:03

SirTakobi marked this pull request as ready for review March 21, 2022 16:28

SirTakobi mentioned this pull request Mar 21, 2022

[12.0][MIG] website_portal_address #883

Closed

yajo mentioned this pull request Sep 21, 2022

oca-cla-bot fails with old commits and old emails OCA/oca-github-bot#209

Open

eLBati suggested changes Mar 22, 2022

View reviewed changes

SirTakobi requested a review from eLBati March 22, 2022 16:37

SirTakobi force-pushed the 12.0-mig-website_portal_contact branch 2 times, most recently from 8633598 to 87aa49b Compare March 23, 2022 11:35

eLBati approved these changes Mar 23, 2022

View reviewed changes

tarteo requested changes Apr 1, 2022

View reviewed changes

SirTakobi force-pushed the 12.0-mig-website_portal_contact branch from 87aa49b to fca3640 Compare April 1, 2022 13:44

SirTakobi requested a review from tarteo April 1, 2022 13:51

SirTakobi marked this pull request as draft April 7, 2022 13:30

SirTakobi requested a review from eLBati April 7, 2022 14:07

eLBati approved these changes Apr 7, 2022

View reviewed changes

SirTakobi marked this pull request as ready for review April 7, 2022 14:32

tarteo approved these changes Apr 7, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 7, 2022

mrcast approved these changes Apr 8, 2022

View reviewed changes

SirTakobi added 3 commits May 4, 2022 10:04

[IMP] website_portal_contact: Edit and create only children partners

e3df206

[IMP] website_portal_contact: Go back to contacts list after creation…

6eba968

… or update

SirTakobi force-pushed the 12.0-mig-website_portal_contact branch from 603c4e4 to 6eba968 Compare May 4, 2022 08:05

OCA-git-bot added the bot is merging ⏳ label May 4, 2022

OCA-git-bot merged commit ba9d1d5 into OCA:12.0 May 4, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 4, 2022

SirTakobi mentioned this pull request May 4, 2022

[MIG][12.0] website_portal_contact (continuation of PR #701) #840

Closed

mathben mentioned this pull request Jul 21, 2022

[MIG] website_portal_contact: Migration to 12.0 #701

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] website_portal_contact #882

[12.0][MIG] website_portal_contact #882

SirTakobi commented Mar 21, 2022 •

edited

Loading

oca-clabot commented Mar 21, 2022

SirTakobi commented Mar 21, 2022

mathben commented Mar 21, 2022

SirTakobi commented Mar 21, 2022

yajo commented Mar 22, 2022

eLBati left a comment

eLBati left a comment

tarteo left a comment

SirTakobi commented Apr 1, 2022 •

edited

Loading

eLBati left a comment

tarteo left a comment

OCA-git-bot commented Apr 7, 2022

mrcast left a comment

tarteo commented Apr 8, 2022

OCA-git-bot commented Apr 8, 2022

SirTakobi commented Apr 8, 2022

SirTakobi commented May 4, 2022

hbrunn commented May 4, 2022

SirTakobi commented May 4, 2022

hbrunn commented May 4, 2022

OCA-git-bot commented May 4, 2022

OCA-git-bot commented May 4, 2022

[12.0][MIG] website_portal_contact #882

[12.0][MIG] website_portal_contact #882

Conversation

SirTakobi commented Mar 21, 2022 • edited Loading

oca-clabot commented Mar 21, 2022

SirTakobi commented Mar 21, 2022

mathben commented Mar 21, 2022

SirTakobi commented Mar 21, 2022

yajo commented Mar 22, 2022

eLBati left a comment

Choose a reason for hiding this comment

eLBati left a comment

Choose a reason for hiding this comment

tarteo left a comment

Choose a reason for hiding this comment

SirTakobi commented Apr 1, 2022 • edited Loading

eLBati left a comment

Choose a reason for hiding this comment

tarteo left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 7, 2022

mrcast left a comment

Choose a reason for hiding this comment

tarteo commented Apr 8, 2022

OCA-git-bot commented Apr 8, 2022

SirTakobi commented Apr 8, 2022

SirTakobi commented May 4, 2022

hbrunn commented May 4, 2022

SirTakobi commented May 4, 2022

hbrunn commented May 4, 2022

OCA-git-bot commented May 4, 2022

OCA-git-bot commented May 4, 2022

SirTakobi commented Mar 21, 2022 •

edited

Loading

SirTakobi commented Apr 1, 2022 •

edited

Loading