[12.0][MIG] website_portal_address #883

SirTakobi · 2022-03-21T16:52:38Z

Superseding #702.

~~Depends on #882.~~

Added history with format patch and squashed administrative commits.

SirTakobi · 2022-05-11T08:54:28Z

@OCA/website-maintainers can someone have a look? Thanks!
cc @takobi-online

@Tardo @claudiagn @mathben since you worked in the superseded PR, maybe you are interested in this one too?

SirTakobi · 2022-07-13T07:30:13Z

@OCA/website-maintainers can someone have a look? Thanks!
cc @takobi-online

@Tardo @claudiagn @mathben since you worked in the superseded PR, maybe you are interested in this one too?

mathben · 2022-07-21T23:30:20Z

I approve this pull request.
Can we add test case?

SirTakobi · 2022-07-22T07:08:27Z

I approve this pull request.

Thanks for the approval! Can you leave a Github review? It is just the Github-way to a approve a PR, you can do it like so:

leave a review on GitHub (accessible in the "Review changes" green button on the third tab - Files changed -) with:

Approve if everything worked as expected

Comment or Request changes with the description of the mismatch otherwise.

(from https://odoo-community.org/resources/review)

Can we add test case?

There is already an automated test (see tests/test_ui.py), which additional test case do you think should be added?

mathben · 2022-08-03T07:17:40Z

website_portal_address/controllers/main.py

+            values["state_id"] = False
+        elif values["state_id"]:
+            try:
+                values["state_id"] = int(values["state_id"].split('-', 1)[1])


Add a testcase, a request to call _contacts_clean-values. The dict values need a state_id.
Add a comment to ignore coverage in except ValueError.

I added a test that also covers the except branch, can you check if it's ok for you now? Thanks!

mathben · 2022-08-03T07:17:58Z

website_portal_address/controllers/main.py

+
+        if "country_id" in values and values["country_id"]:
+            try:
+                values["country_id"] = int(values["country_id"])


Add a testcase, a request to call _contacts_clean-values. The dict values need a country_id.
Add a comment to ignore coverage in except ValueError.

I added a test that also covers the except branch, can you check if it's ok for you now? Thanks!

mathben

Thanks for your contribution :-)

mathben · 2022-12-31T04:07:21Z

How can we force the runboat/build?

SirTakobi · 2023-01-02T09:58:29Z

How can we force the runboat/build?

I just tried pushing a new commit

SirTakobi · 2023-02-27T13:42:32Z

CI should be fixed after #958

github-actions · 2023-07-02T12:36:07Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

* [ADD] Added website_portal_address module [ADD] Added website_portal_address module * [REF] pylint and js fixes * [REF] pep-8 correction * Added OCA icon

Currently translated at 100,0% (14 of 14 strings) Translation: website-9.0/website-9.0-website_portal_address Translate-URL: https://translation.odoo-community.org/projects/website-9-0/website-9-0-website_portal_address/ca/

- selected dropbox fix with correct id - add label on fields

- fix hidden address when choose contact

- fix contact to show to only limit with society

[FIX] Remove rule already in parent module [I18N] Italian translations [REF] New README format [FIX] Restore controllers inheritance [MIG] Adapt to changed templates in dependency [REF] Do not overwrite parent template

aleuffre

Code and functional review LGTM

OCA-git-bot · 2023-07-07T13:52:44Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mathben · 2023-10-10T21:04:06Z

How can we rerun the runboat/build? Thanks

github-actions · 2024-03-10T12:28:12Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

SirTakobi force-pushed the 12.0-mig-website_portal_address branch 2 times, most recently from 2640624 to ed91242 Compare March 21, 2022 17:32

SirTakobi marked this pull request as ready for review March 22, 2022 16:34

SirTakobi force-pushed the 12.0-mig-website_portal_address branch 2 times, most recently from f59c470 to c4ea31b Compare May 4, 2022 13:32

mathben mentioned this pull request Jul 21, 2022

[MIG] website_portal_address: Migration to 12.0 #702

Closed

mathben suggested changes Aug 3, 2022

View reviewed changes

SirTakobi force-pushed the 12.0-mig-website_portal_address branch 2 times, most recently from 955096b to 64226d4 Compare August 5, 2022 13:34

SirTakobi requested a review from mathben August 22, 2022 15:06

mathben approved these changes Aug 26, 2022

View reviewed changes

SirTakobi force-pushed the 12.0-mig-website_portal_address branch from 64226d4 to 37f4355 Compare August 26, 2022 07:44

SirTakobi force-pushed the 12.0-mig-website_portal_address branch from 37f4355 to e514631 Compare January 2, 2023 09:57

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 2, 2023

SirTakobi force-pushed the 12.0-mig-website_portal_address branch from e514631 to 67bceb2 Compare July 7, 2023 09:05

JayVora-SerpentCS and others added 7 commits July 7, 2023 11:06

[ADD] added the website_portal_address (OCA#273)

23ef900

* [ADD] Added website_portal_address module [ADD] Added website_portal_address module * [REF] pylint and js fixes * [REF] pep-8 correction * Added OCA icon

Translated using Weblate (català)

515f748

Currently translated at 100,0% (14 of 14 strings) Translation: website-9.0/website-9.0-website_portal_address Translate-URL: https://translation.odoo-community.org/projects/website-9-0/website-9-0-website_portal_address/ca/

[MIG] website_portal_address: Migration to 12.0

00c287c

[REF] website_portal_address: Black python code

adaa3c3

[FIX] website_portal_address: fix country and state form

9ebfe8f

- selected dropbox fix with correct id - add label on fields

[ADD] website_portal_address: translate fr_CA.po

a32e998

[ADD] website_portal_address: add tour test_ui

f13a50a

mathben added 3 commits July 7, 2023 11:06

[FIX] website_portal_address: filter state by country

ad12273

- fix hidden address when choose contact

[ADD] website_portal contact and address: show society for root contact

1f13ada

- fix contact to show to only limit with society

[ADD] website_portal: manage permission to edit contact

c8efaf1

SirTakobi force-pushed the 12.0-mig-website_portal_address branch from 67bceb2 to dfeeb2c Compare July 7, 2023 09:06

[MIG] website_portal_address

edf4a11

[FIX] Remove rule already in parent module [I18N] Italian translations [REF] New README format [FIX] Restore controllers inheritance [MIG] Adapt to changed templates in dependency [REF] Do not overwrite parent template

SirTakobi force-pushed the 12.0-mig-website_portal_address branch from dfeeb2c to edf4a11 Compare July 7, 2023 10:22

aleuffre approved these changes Jul 7, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 7, 2023

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 9, 2023

OpenCode approved these changes Nov 8, 2023

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 10, 2024

github-actions bot closed this Apr 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] website_portal_address #883

[12.0][MIG] website_portal_address #883

SirTakobi commented Mar 21, 2022 •

edited

Loading

SirTakobi commented May 11, 2022

SirTakobi commented Jul 13, 2022

mathben commented Jul 21, 2022

SirTakobi commented Jul 22, 2022

mathben Aug 3, 2022

SirTakobi Aug 5, 2022

mathben Aug 3, 2022

SirTakobi Aug 5, 2022

mathben left a comment

mathben commented Dec 31, 2022

SirTakobi commented Jan 2, 2023 •

edited

Loading

SirTakobi commented Feb 27, 2023

github-actions bot commented Jul 2, 2023

aleuffre left a comment

OCA-git-bot commented Jul 7, 2023

mathben commented Oct 10, 2023

github-actions bot commented Mar 10, 2024

[12.0][MIG] website_portal_address #883

[12.0][MIG] website_portal_address #883

Conversation

SirTakobi commented Mar 21, 2022 • edited Loading

SirTakobi commented May 11, 2022

SirTakobi commented Jul 13, 2022

mathben commented Jul 21, 2022

SirTakobi commented Jul 22, 2022

mathben Aug 3, 2022

Choose a reason for hiding this comment

SirTakobi Aug 5, 2022

Choose a reason for hiding this comment

mathben Aug 3, 2022

Choose a reason for hiding this comment

SirTakobi Aug 5, 2022

Choose a reason for hiding this comment

mathben left a comment

Choose a reason for hiding this comment

mathben commented Dec 31, 2022

SirTakobi commented Jan 2, 2023 • edited Loading

SirTakobi commented Feb 27, 2023

github-actions bot commented Jul 2, 2023

aleuffre left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jul 7, 2023

mathben commented Oct 10, 2023

github-actions bot commented Mar 10, 2024

SirTakobi commented Mar 21, 2022 •

edited

Loading

SirTakobi commented Jan 2, 2023 •

edited

Loading