Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] website_portal_address: Migration to 12.0 #702

Closed
wants to merge 15 commits into from

Conversation

mathben
Copy link

@mathben mathben commented Mar 7, 2020

Depends on website_portal_contact #701

@mathben mathben force-pushed the 12.0-mig-website_portal_address branch from 03e796c to c7d420c Compare March 8, 2020 01:06
@mathben mathben force-pushed the 12.0-mig-website_portal_address branch from c7d420c to 1853ac3 Compare March 8, 2020 21:43
@mathben mathben force-pushed the 12.0-mig-website_portal_address branch 2 times, most recently from e4a77ea to e0ca77c Compare March 9, 2020 03:34
- fix hidden address when choose contact
@mathben mathben force-pushed the 12.0-mig-website_portal_address branch from e0ca77c to 9f96122 Compare March 9, 2020 03:45
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, preserve commit history and clean the PR to only have "website_portal_address" changes...

@HaraldPanten
Copy link

Hi @mathben ,

Are you going to continue this PR?

@mathben
Copy link
Author

mathben commented Aug 6, 2020

Hi @HaraldPanten , your help is appreciated. I need to merge first #701
Thanks

@HaraldPanten
Copy link

Hi @HaraldPanten , your help is appreciated. I need to merge first #701
Thanks

Sure, I will 👍

Copy link
Contributor

@claudiagn claudiagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathben let me know when you do the merge so we can review this 👍

@mathben
Copy link
Author

mathben commented Jul 21, 2022

Close, continue into #883

@mathben mathben closed this Jul 21, 2022
matteoopenf pushed a commit to matteoopenf/website that referenced this pull request Feb 17, 2023
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants