Support for COBOL CFG display with graphviz and d3
#368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix package.json
nberth
reviewed
Sep 9, 2024
NeoKaios
force-pushed
the
feat/cobol-cfg
branch
from
d041e89
to
6594f5c
Compare
- isolated CFG_options module, add mli for Cfg_builder - improve desc of commands - Ensure no silent error on asset file reading - add new cfg_type for clarity
- add history to go back to previous graphs
nberth
reviewed
Sep 26, 2024
assets/cfg-d3-renderer.html
Outdated
There was a problem hiding this comment.
I'm not sure to see what .html file in assets is actually used: could you add a comment in them to describe what they are used for? Also they possibly need a license header (at least those with code I think).
There was a problem hiding this comment.
Which one ? OCAMLPRO-NON-COMMERCIAL license ?
There was a problem hiding this comment.
I only skimmed through this file, which appears fine as a draft. Some changes will be needed (possibly later) to avoid doing the actual export in this library (which should mostly be about internal CFG representation and construction, with possibly a Cobol_cfg.As_dot module which may be helpful in other contexts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocaml-graphdependency to generated a dot graph of the CFG of a COBOL program / section