Support for COBOL CFG display with graphviz and d3
#368
Conversation
NeoKaios
force-pushed
the
feat/cobol-cfg
branch
from
d041e89
to
6594f5c
Compare
There was a problem hiding this comment.
I only skimmed through this file, which appears fine as a draft. Some changes will be needed (possibly later) to avoid doing the actual export in this library (which should mostly be about internal CFG representation and construction, with possibly a Cobol_cfg.As_dot module which may be helpful in other contexts).
src/lsp/cobol_cfg/cfg_options.ml
Outdated
| shatter_hubs: int option; | ||
| transformation: transformation option; | ||
| hidden_nodes: int list; | ||
| split_nodes: int list; |
There was a problem hiding this comment.
Note sure what those two last lists correspond to. What do the ints correspond to?
There was a problem hiding this comment.
They correspond to node ids
There was a problem hiding this comment.
Could you add a comment to specify where these IDs come from? Do they come from a previous CFG construction? (there's an integrity issue here, but that may still be ok for now).
fix package.json
- isolated CFG_options module, add mli for Cfg_builder - improve desc of commands - Ensure no silent error on asset file reading - add new cfg_type for clarity
- add history to go back to previous graphs
Co-authored-by: Nicolas Berthier <[email protected]>
NeoKaios
force-pushed
the
feat/cobol-cfg
branch
from
7f9d3be
to
617734a
Compare
| Lsp_cfg.doc_to_cfg_jsoono ~filename:uri ~name ~options checked_doc | ||
| in Some jsoono | ||
| end |> | ||
| Option.get |
There was a problem hiding this comment.
Not sure why there's a need for Option.get here. Like most other requests the payload of replies should also be made optional to account for improper uses of the requests, and those cases dealt with on the client side.
(That'll be fixed later though)
|
@NeoKaios Could you just add the "Added: CFG explorer for COBOL programs" in |
|
Thanks! |
ocaml-graphdependency to generated a dot graph of the CFG of a COBOL program / section