Detect prefilter events 6728 v1 #1992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2024
catenacyber
force-pushed
the
detect-prefilter-events-6291-v1
branch
from
6041440
to
4e4dafd
Compare
| @@ -1,3 +1,4 @@ | |||
| alert tcp any any -> any any (msg:"TCP packet too small"; decode-event:tcp.pkt_too_small; sid:1;) | |||
| alert tcp any any -> any any (msg:"TCP packet too small"; decode-event:tcp.pkt_too_small; prefilter; requires: version >= 8; sid:1; rev: 2;) | |||
There was a problem hiding this comment.
sid 2 is already in this file
There was a problem hiding this comment.
any reason to use this pattern? Might as well have 2 rules side by side, to test both prefilter and non-prefilter path
There was a problem hiding this comment.
any reason to use this pattern?
This way, it works on both suricata 7 and suricata 8
If you have another rule side by side, you need the whole test to have min-version 8 as suricata 7 does not support prefilter on decode-event
And this is also a good example/showcase of the requires keyword : you load the better rule if suricata version allows it
This was referenced Jul 29, 2024
|
Continued in #2001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6728