Warnint 64to32 6186 v19.2 #10224
Closed
Warnint 64to32 6186 v19.2 #10224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6186 Warnings about downcast from 64 to 32 bits Generic fixes required to get app-layer clean
Ticket: OISF#6186 Warnings about downcast from 64 to 32 bits
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10224 +/- ##
==========================================
+ Coverage 82.18% 82.20% +0.01%
==========================================
Files 977 977
Lines 271894 271937 +43
==========================================
+ Hits 223465 223540 +75
+ Misses 48429 48397 -32
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: ERROR: QA failed on SURI_TLPW1_files_sha256.
Pipeline 17723 |
|
Replaced by #10683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32warnings for some files (a*)First commit of #9840
#9878 rebased now that OISF/libhtp#399 was merged
There must be some stuff to review more carefully