Warnint 64to32 6186 v18.2 #9878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6186 Warnings about downcast from 64 to 32 bits Generic fixes required to get app-layer clean
Ticket: OISF#6186 Warnings about downcast from 64 to 32 bits
This was referenced Nov 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9878 +/- ##
=======================================
Coverage 82.45% 82.45%
=======================================
Files 973 973
Lines 273063 273106 +43
=======================================
+ Hits 225155 225195 +40
- Misses 47908 47911 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16702 |
|
Replaced by #10224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32warnings for some filesOISF/libhtp#399
First commit of #9840
#9875 with clean CI and commit history
There must be some stuff to review more carefully