output/alert: rewrite code for app-layer properties #9034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially fix setup-app-layer script to not forget this part
catenacyber
force-pushed
the
output-alert-applayer-v7.2
branch
from
cc2b88a
to
ef8ef57
Compare
as is done for http2 events and alerts. The http.version integer can help to determine if this is HTTP2
|
Information: QA ran without warnings. Pipeline 14682 |
|
WARNING:
Pipeline 14718 |
This was referenced Jun 20, 2023
|
Replaced by #9053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None, preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins
Part of #8961 with rebase
Describe changes:
After that, there is still from #8961
SimpleTxLogFuncfrom a JsonGenericLogger to remove many C filesModifies #9005 by making logger functions opening the object + reusing HTTP2 logger for file output