Output alert applayer v8.2 #9053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as is done for http2 events and alerts. The http.version integer can help to determine if this is HTTP2 Ticket: OISF#6165
Especially fix setup-app-layer script to not forget this part
catenacyber
requested review from
jasonish,
victorjulien and
a team
as code owners
|
WARNING:
Pipeline 14744 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9053 +/- ##
==========================================
- Coverage 82.32% 78.60% -3.73%
==========================================
Files 969 969
Lines 273655 273325 -330
==========================================
- Hits 225292 214850 -10442
- Misses 48363 58475 +10112
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Converting to draft to focus on first merging #9052 |
|
Replaced by #9182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None, preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins
Part of #8961 with rebase
Actually there is https://redmine.openinfosecfoundation.org/issues/3827
Describe changes:
After that, there is still from #8961
SimpleTxLogFuncfrom a JsonGenericLogger to remove many C filesModifies #9034 by rebasing on top of #9052 that fixes files output for HTTP2
OISF/suricata-verify#1262