Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.0.x: backport RFB fixes #9232

Closed
wants to merge 5 commits into from
Closed

6.0.x: backport RFB fixes #9232

wants to merge 5 commits into from

Conversation

satta
Copy link
Contributor

@satta satta commented Jul 13, 2023

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5915

Describe changes:

@satta
rfb: be more strict parsing the version
7fd9360
@satta
rfb: add myself as contributor
e74f04c
@satta
rfb: never return error on unknown traffic
c7fd790 
We only try to parse a small subset of what is possible in
RFB. Currently we only understand some standard auth schemes
and stop parsing when the server-client handshake is complete.
Since in IPS mode returning an error from the parser causes
drops that are likely uncalled for, we do not want to return
errors when we simply do not understand what happens in the
traffic. This addresses Redmine OISF#5912.

Bug: OISF#5915.
@satta
rfb: ensure logging of incompletely parsed txs
4161f96
@satta
rfb: also set unimplemented auth types
59876ab
@satta satta requested review from victorjulien, jasonish and a team as code owners July 13, 2023 20:13
@catenacyber
Copy link
Contributor

Could you run git cherry-pick -x with -xoption adding a reference to the original commit ?

CI failure seems fixable by cherry-picking ce05511 merged a few hours ago

@satta
Copy link
Contributor Author

satta commented Jul 14, 2023

Could you run git cherry-pick -x with -xoption adding a reference to the original commit ?

Oof, these cherry-picks took >1h of manual fixing. I'd rather not cherry-pick again from the original commits but add the commit references to the current ones manually, making them look like git cherry-pick -x output.

CI failure seems fixable by cherry-picking ce05511 merged a few hours ago

Thanks, will also add that.

@satta satta mentioned this pull request Jul 14, 2023
Closed
@satta
Copy link
Contributor Author

satta commented Jul 14, 2023

New PR: #9234

@satta satta closed this Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satta @catenacyber