Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.0.x: backport RFB fixes #9232

Closed
wants to merge 5 commits into from
Closed

6.0.x: backport RFB fixes #9232

wants to merge 5 commits into from

Commits on Jul 11, 2023

  1. rfb: be more strict parsing the version

    @satta
    satta committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    7fd9360 View commit details
    Browse the repository at this point in the history

  2. rfb: add myself as contributor

    @satta
    satta committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    e74f04c View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. rfb: never return error on unknown traffic 

    We only try to parse a small subset of what is possible in
RFB. Currently we only understand some standard auth schemes
and stop parsing when the server-client handshake is complete.
Since in IPS mode returning an error from the parser causes
drops that are likely uncalled for, we do not want to return
errors when we simply do not understand what happens in the
traffic. This addresses Redmine OISF#5912.

Bug: OISF#5915.
    @satta
    satta committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    c7fd790 View commit details
    Browse the repository at this point in the history

  2. rfb: ensure logging of incompletely parsed txs

    @satta
    satta committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    4161f96 View commit details
    Browse the repository at this point in the history

  3. rfb: also set unimplemented auth types

    @satta
    satta committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    59876ab View commit details
    Browse the repository at this point in the history