output/alert: rewrite code for app-layer properties #9252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially fix setup-app-layer script to not forget this part Ticket: OISF#3827
catenacyber
requested review from
jasonish,
victorjulien and
a team
as code owners
|
Information: QA ran without warnings. Pipeline 15329 |
jasonish
reviewed
Sep 14, 2023
Comment on lines
+211
to
+216
| typedef bool (*SimpleTxLogFunc)(void *, struct JsonBuilder *); | ||
|
|
||
| typedef struct AppLayerLogger { | ||
| AppProto proto; | ||
| SimpleTxLogFunc LogTx; | ||
| } AppLayerLogger; |
There was a problem hiding this comment.
From a code organization perspective, I'd like to see output.[ch] just deal with the core/raw logging registration, which JSON/EVE should not be a part of. So this looks a bit more like a JsonAppLayerLogger, and SimpleTxLogFunc looks more like a SimpleJsonTxLogFunc, or maybe simply JsonTxLogFunc?
There was a problem hiding this comment.
Ok for renaming.
SimpleJsonTxLogFunc does not cover all the cases (when the state is needed, to when some option flags are passed)
|
Continued in #9499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3827
preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins
preliminary work for https://redmine.openinfosecfoundation.org/issues/5977 as well
Part of #8961
Describe changes:
After that, there is still from #8961
SimpleTxLogFuncfrom a JsonGenericLogger to remove many C filesRebase of #9182