output/alert: rewrite code for app-layer properties #9499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
requested review from
jasonish,
victorjulien and
a team
as code owners
|
WARNING:
Pipeline 15991 |
catenacyber
force-pushed
the
output-alert-applayer-v11
branch
from
803092e
to
d6ee22b
Compare
Especially fix setup-app-layer script to not forget this part Ticket: OISF#3827
catenacyber
force-pushed
the
output-alert-applayer-v11
branch
from
d6ee22b
to
1e77969
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9499 +/- ##
==========================================
- Coverage 82.18% 82.16% -0.02%
==========================================
Files 968 968
Lines 274203 274059 -144
==========================================
- Hits 225352 225181 -171
- Misses 48851 48878 +27
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
CANCELED: | field | baseline | test | % | Pipeline 16004 |
|
Why did you mark this as draft ? It is ready for me... |
|
Information: QA ran without warnings. Pipeline 16042 |
|
Replaced by #9511 |
Messy PR history with failures, force pushes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3827
preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins
preliminary work for https://redmine.openinfosecfoundation.org/issues/5977 as well
Part of #8961
Describe changes:
After that, there is still from #8961
SimpleTxLogFuncfrom a JsonGenericLogger to remove many C files#9252 with some renaming as per code review + reusing code for output-json-file.c