Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/multi-tenant: Make tenant_id 32 bits everywhere #9259

Closed
wants to merge 2 commits into from

Conversation

jlucovsky
Copy link
Contributor

Issue: 6047

This commit ensures that the tenant id is contained in a unsigned 32 bit container.

(cherry picked from commit 9fd77c7)
Continuation of #9247

Link to redmine ticket: 6220

Describe changes:

  • Cherry-pick tenant-id size change

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

jlucovsky and others added 2 commits July 18, 2023 08:36
Issue: 6047

This commit ensures that the tenant id is contained in a unsigned 32 bit
container.

(cherry picked from commit 9fd77c7)
(cherry picked from commit ce05511)
(cherry picked from commit cedee76)
@suricata-qa
Copy link

Information:

field baseline test %
TREX_GENERIC_stats_chk
.capture.kernel_drops 0 40956 0.01

Pipeline 15317

@ct0br0
Copy link

ct0br0 commented Jul 19, 2023

Going to run TREX_GENERIC again.

@ct0br0
Copy link

ct0br0 commented Jul 19, 2023

Second run looked fine 👍

@victorjulien
Copy link
Member

Needs rebase and cherry-pick line fixups.

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comment

@jlucovsky
Copy link
Contributor Author

Continued in #9263

@jlucovsky jlucovsky closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants