Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output alert applayer v16.1 #9869

Closed
wants to merge 4 commits into from
Closed

Output alert applayer v16.1 #9869

wants to merge 4 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3827
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • output: unify boilerplate code (trying to become a lines-of-code neutral contributor to Suricata ;-) and rising the percentage of rust files )
  • output/dns: do not add empty app-layer metadata
  • app-layer: do not require probing parser as fixed patterns can be enough
  • dnp3: restrict function scope to one file

Follow up after large of #9851 (part of #9812 for app-layer plugins)

@jasonish what do you think about the DNS commit ?

Should I split this into multiple PRs ?

@catenacyber catenacyber mentioned this pull request Nov 23, 2023
Closed
@catenacyber
Copy link
Contributor Author

Replaced by #9870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@catenacyber