-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output alert applayer v17.1 #9870
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 3827
as fixed patterns can be enough
This was referenced Nov 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9870 +/- ##
==========================================
+ Coverage 82.45% 82.47% +0.01%
==========================================
Files 973 961 -12
Lines 273063 272672 -391
==========================================
- Hits 225155 224875 -280
+ Misses 47908 47797 -111
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 16694 |
Looks fine, this is good. |
This was referenced Dec 7, 2023
Closed
This was referenced Jan 2, 2024
Closed
Closed
Closed
Closed
This was referenced Jan 15, 2024
Closed
Rebased in #10166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3827
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
There is one behavior change for SSH switching from
LOG_DIR_PACKET
toLOG_DIR_FLOW
What do you think about it ?
Follow up after large of #9851 (part of #9812 for app-layer plugins)
#9869 with right commit pushed
@jasonish what do you think about the DNS commit ?
Should I split this into multiple PRs ?
OISF/suricata-verify#1490