Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general/cppcheck: Address cppcheck memory related errors #9891

Closed
wants to merge 1 commit into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #9866

Address cppcheck reported memory leak/misuse errors. See the redmine issue for the cppcheck command that uncovered the issues.

Issue: 6527

Link to redmine ticket: 6527

Updates:

  • Fix issue with using assert; converted to BUG_ON

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Address cppcheck reported memory leak/misuse errors. See the redmine
issue for the cppcheck command that uncovered the issues.

Issue: 6527
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Merging #9891 (a97f34d) into master (d005fff) will decrease coverage by 0.10%.
The diff coverage is 72.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9891      +/-   ##
==========================================
- Coverage   82.45%   82.36%   -0.10%     
==========================================
  Files         972      972              
  Lines      273057   273063       +6     
==========================================
- Hits       225156   224906     -250     
- Misses      47901    48157     +256     
Flag Coverage Δ
fuzzcorpus 64.23% <72.00%> (-0.14%) ⬇️
suricata-verify 61.04% <12.00%> (-0.05%) ⬇️
unittests 62.91% <12.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jlucovsky
Copy link
Contributor Author

Continued in #9892

@jlucovsky jlucovsky closed this Nov 25, 2023
@jlucovsky jlucovsky deleted the 6527/3 branch December 19, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant