general/cppcheck: Address cppcheck memory related errors #9892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 6527 Ensure that the `map->string` memory isn't leaked following an error return from `HashListTableAdd`
Issue: 6527 Address the FP raised by cppcheck -- note that although the code corectly checks to ensure that `to_shift != &sb->reqion`, the logic was detected as a FP. Rework the code to eliminate the FP.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9892 +/- ##
==========================================
- Coverage 82.45% 82.37% -0.09%
==========================================
Files 972 972
Lines 273057 273062 +5
==========================================
- Hits 225156 224923 -233
- Misses 47901 48139 +238
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16727 |
victorjulien
approved these changes
Dec 13, 2023
Merged
|
Merged in #10043, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #9891
Address cppcheck reported memory leak/misuse errors. See the redmine issue for the cppcheck command that uncovered the issues.
Issue: 6527
Link to redmine ticket: 6527
Updates:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis thepull request number.
Alternatively,
SV_BRANCHmay also be a link to anOISF/suricata-verify pull-request.