Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorg: modular file reorganization of C source code - v6 #9960

Closed
wants to merge 34 commits into from

Conversation

jasonish
Copy link
Member

@jasonish jasonish commented Dec 5, 2023

Continuation of #9957

Changes from previous PR:

  • Remove clang-format from single line arrays
  • More protocols
  • "EVE" output files not related to an app-layer in output/eve
  • Other output files into output
  • util-* into util/

TODO:

  • Other log should go into output as well

@suricata-qa
Copy link

WARNING:

field baseline test %
build_asan

Pipeline 16863

@jasonish
Copy link
Member Author

jasonish commented Dec 5, 2023

A file got lost, util-config.[ch] to util/config.[ch], but anyways, its more about the overall structure.

@inashivb
Copy link
Member

inashivb commented Dec 5, 2023

Tips on how does one go about reviewing a PR of this order and length?

@jasonish
Copy link
Member Author

jasonish commented Dec 5, 2023

Tips on how does one go about reviewing a PR of this order and length?

At this point, probably sampling a few of the commits in the PR to make sure they're reorganzing their item of interest in s a sane way.

@jasonish
Copy link
Member Author

jasonish commented Dec 5, 2023

The last commit, the util reorg is causing build failures.

@jasonish
Copy link
Member Author

jasonish commented Dec 5, 2023

The building is fixed at #9973.

@jasonish jasonish closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants