Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebpf: Update eBPF map to BTF defined map #9969

Closed
wants to merge 1 commit into from

Conversation

vincentmli
Copy link
Contributor

@vincentmli vincentmli commented Dec 5, 2023

legacy map definition is removed from libbpf1.0+.
update the legacy map definition to BTF defined map.

Distros with < libbpf1.0 (0.5, 0.6, 0.7, 0.8) bpf_helpers.h support BTF map definition, this change does not break old libbpf and support new libpbf1.0+.

Bug: #6250

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

Describe changes:

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

legacy map definition is removed from libbpf1.0+.
update the legacy map definition to BTF defined map.

Distros with < libbpf1.0 (0.5, 0.6, 0.7, 0.8) bpf_helpers.h
support BTF map definition, this change does not break
old libbpf and support new libpbf1.0+.

Bug: OISF#6250

Signed-off-by: Vincent Li <[email protected]>
Co-authored-by: Victor Julien <[email protected]>
@vincentmli vincentmli requested review from jasonish and a team as code owners December 5, 2023 16:32
@vincentmli
Copy link
Contributor Author

Hi @victorjulien, I rebased on master and send up this new clean PR per your request, thanks for review

@victorjulien victorjulien added this to the 8.0 milestone Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

NOTE: This PR may contain new authors.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #9969 (ef4c855) into master (13cc493) will increase coverage by 0.02%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9969      +/-   ##
==========================================
+ Coverage   82.39%   82.41%   +0.02%     
==========================================
  Files         970      970              
  Lines      271359   271359              
==========================================
+ Hits       223586   223642      +56     
+ Misses      47773    47717      -56     
Flag Coverage Δ
fuzzcorpus 64.46% <ø> (+0.01%) ⬆️
suricata-verify 61.31% <ø> (+<0.01%) ⬆️
unittests 62.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien
Copy link
Member

Merged in #9978, thanks!

@vincentmli vincentmli deleted the vli-ebpf branch February 1, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants