next/211/20231205/v1 #9978
Merged
next/211/20231205/v1 #9978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had unkonwn message type for the backend, but not the frontend messages. It's important to better identify those to improve pgsql probing functions. Related to Bug OISF#6080
Some non-pgsql traffic seen by Suricata is mistankenly identified as pgsql, as the probing function is too generic. Now, if the parser sees an unknown message type, even if it looks like pgsql, it will fail. Bug OISF#6080
With the changes in the probing_ts function, this other one could become obsolete. Remove it, and directly call `parser::parse_request` when checking for gaps, instead.
legacy map definition is removed from libbpf1.0+. update the legacy map definition to BTF defined map. Distros with < libbpf1.0 (0.5, 0.6, 0.7, 0.8) bpf_helpers.h support BTF map definition, this change does not break old libbpf and support new libpbf1.0+. Bug: OISF#6250 Signed-off-by: Vincent Li <[email protected]> Co-authored-by: Victor Julien <[email protected]>
victorjulien
requested review from
jufajardini,
jasonish and
a team
as code owners
|
NOTE: This PR may contain new authors. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9978 +/- ##
==========================================
- Coverage 82.42% 82.41% -0.01%
==========================================
Files 970 970
Lines 271363 271356 -7
==========================================
- Hits 223667 223648 -19
- Misses 47696 47708 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Dec 5, 2023
|
WARNING:
Pipeline 16885 |
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=pr/1513