Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent link param naming footer/header #1826

Closed
rmccar opened this issue Jan 19, 2022 · 0 comments · Fixed by #2741
Closed

Inconsistent link param naming footer/header #1826

rmccar opened this issue Jan 19, 2022 · 0 comments · Fixed by #2741
Assignees
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.

Comments

@rmccar
Copy link
Contributor

rmccar commented Jan 19, 2022

Inconsistent param naming for the text for header nav links and footer links. I think this should be changed so they both use text for the link text param

Footer uses text:

"itemsList": [
    {
        "text": 'Cookies and privacy',
        "url": '#0'
    }
]

Header uses title:

"itemsList": [
    {
        "title": "Help",
        "url": "#0"
    }
]
@yatesn yatesn added the Tech improvements Tech debt, cleanup, code standardisation etc. label Jan 28, 2022
@yatesn yatesn added size: 1 and removed size: 1 labels Apr 22, 2022
@willcAND willcAND self-assigned this Jul 18, 2023
@willcAND willcAND added the Breaking changes This PR contains at least one breaking change label Jul 18, 2023
@willcAND willcAND removed the Breaking changes This PR contains at least one breaking change label Jul 20, 2023
@willcAND willcAND linked a pull request Jul 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants