Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/1826/header footer param naming #2741

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

willcAND
Copy link
Contributor

What is the context of this PR?

#1826

How to review

Load up header examples, confirm all look correct.

@willcAND willcAND self-assigned this Jul 20, 2023
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 4a14ee5
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/64b9075f783d45000880efee
😎 Deploy Preview https://deploy-preview-2741--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@willcAND willcAND linked an issue Jul 21, 2023 that may be closed by this pull request
@willcAND willcAND added the Enhancement Change of existing feature label Jul 21, 2023
@willcAND willcAND merged commit ab218c1 into main Jul 24, 2023
7 checks passed
@willcAND willcAND deleted the enhancement/1826/header-footer-param-naming branch July 24, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent link param naming footer/header
3 participants