Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pta: stats: add commands to print clock and regulator trees #6521

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

etienne-lms
Copy link
Contributor

Add statistics PTA commands STATS_CMD_PRINT_DRIVERS_INFO to print device drivers information on console. The implementation currently allows to print the clock tree and the regulator tree to core console.

This is a follow-up of changes discussed in #6481.

I have picked commit "drivers: regulator: fix variable sized voltages fallback" from P-R #6487 latest state to ensure pta_stats.c successfully builds with clang (inclusion of regulator.h). I'll remove this commit and rebase this P-R on top of #6487 once its merged.

@etienne-lms
Copy link
Contributor Author

@jforissier, in #6481 (comment) you asked from the PTA command name to be singular (s/STATS_CMD_PRINT_DRIVERS_INFO/STATS_CMD_PRINT_DRIVER_INFO/). I've restored the plural form as printing clock or regulator trees relate to several drivers rather than not a single one. Thinking twice, in the end, maybe singular is more appropriate...

@jforissier
Copy link
Contributor

@etienne-lms AFAICT singular tends to be more common when a noun is used as an adjective. I believe "driver info" is OK to mean "information about one or more driver(s)".

@etienne-lms
Copy link
Contributor Author

Ok, I'll update.

@jforissier
Copy link
Contributor

For " pta: stats: add commands to print clock and regulator trees" with fixup:

Reviewed-by: Jerome Forissier <[email protected]>

Do you have the xtest side of things?

@etienne-lms
Copy link
Contributor Author

Do you have the xtest side of things?

Yes, I was waiting for #6499 to land first.
I'll create the P-R.

@etienne-lms
Copy link
Contributor Author

Do you have the xtest side of things?

OP-TEE/optee_test#717

@etienne-lms
Copy link
Contributor Author

By the way, testing with various configuration settings I saw an optee_os build issue when CFG_TA_STATS=y CFG_WITH_STATS=n. Are you ok I append the fix (proposal) to this P-R or would you prefer a dedicated P-R?

Add statistics PTA commands STATS_CMD_PRINT_DRIVERS_INFO to print
device drivers information on console. The implementation currently
allows to print the clock tree and the regulator tree to core console.

Reviewed-by: Jerome Forissier <[email protected]>
Signed-off-by: Etienne Carriere <[email protected]>
@etienne-lms
Copy link
Contributor Author

I've rebased on master tip since #6487 has been merged.
Review tag applied.

@jforissier
Copy link
Contributor

By the way, testing with various configuration settings I saw an optee_os build issue when CFG_TA_STATS=y CFG_WITH_STATS=n. Are you ok I append the fix (proposal) to this P-R or would you prefer a dedicated P-R?

Please open a new PR, this one can be merged now. Thanks!

@jforissier jforissier merged commit a5e75b7 into OP-TEE:master Dec 4, 2023
7 checks passed
@etienne-lms etienne-lms deleted the pta-stats branch December 5, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants