xtest: stats: used exported PTA API + print clock/regulator trees #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
reviewed
Dec 4, 2023
| @@ -59,6 +33,8 @@ static int usage(void) | |||
| fprintf(stderr, " --memleak Dump memory leak data on secure console\n"); | |||
| fprintf(stderr, " --ta Print loaded TAs context\n"); | |||
| fprintf(stderr, " --time Print REE and TEE time\n"); | |||
| fprintf(stderr, " --clocks Dump clock tree on secure console\n"); | |||
| fprintf(stderr, " --regulators Dump regulator tree on secure console\n"); | |||
There was a problem hiding this comment.
Right, sorry, i'll fix.
Thanks.
|
comment above addressed. |
jforissier
approved these changes
Dec 5, 2023
Rely on pta_stats.h header file for the statistics PTA API definition rather than using a local definition. Reviewed-by: Jerome Forissier <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
Add 'xtest --stats' options '--clocks' and '--regulators' to respectively dump OP-TEE core clock tree and regulator tree to the secure console. Reviewed-by: Jerome Forissier <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
|
review tag applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This P-R depends on OP-TEE/optee_os#6521.