Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grass.jupyter: Add SeriesMap and tests #2996

Closed
wants to merge 9 commits into from
Closed

Conversation

chaedri
Copy link
Contributor

@chaedri chaedri commented Jun 3, 2023

Based off TimeSeriesMap, SeriesMap creates a ipywidgets Slider for scrolling between a list of rasters and/or vectors.

series = gj.SeriesMap(height = 500)
series.add_rasters(["elevation_shade", "geology", "soils"])
series.add_vectors(["streams", "streets", "viewpoints"])
series.d_barscale()
series.show()  # Create Slider

@chaedri chaedri added the enhancement New feature or request label Jun 3, 2023
@chaedri chaedri changed the title Add RasterSeriesMap and tests grass.jupyter: Add RasterSeriesMap and tests Jun 3, 2023
@chaedri
Copy link
Contributor Author

chaedri commented Jun 3, 2023

Outstanding questions for this PR:

  • There's some duplicate code here with TimeSeriesMap; should there be shared functions between them?
  • This is not the most efficient way of doing this but I'm not sure of a better way.
  • Vector styling should be improved

@chaedri chaedri marked this pull request as draft June 3, 2023 10:49
@chaedri chaedri changed the title grass.jupyter: Add RasterSeriesMap and tests grass.jupyter: Add SeriesMap and tests Jun 6, 2023
@chaedri chaedri requested a review from petrasovaa June 6, 2023 10:32
@chaedri chaedri marked this pull request as ready for review June 6, 2023 10:36
@chaedri chaedri marked this pull request as draft June 6, 2023 12:03
@chaedri
Copy link
Contributor Author

chaedri commented Jun 6, 2023

Replaced by #3036

@chaedri chaedri closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

1 participant