-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grass.jupyter: add SeriesMap and tests #3036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Just the test and flake8 are failing and I added couple comments.
@wenzeslaus I'm having trouble getting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create an issue for the duplicate code. One issue just for the specific code issue is enough. The Pylint config is part of a bigger issue of reducing Pylint warnings.
Co-authored-by: Vaclav Petras <[email protected]>
The only check that isn't passing is pytest. It passes on my local ubuntu machine but fails in GitHub actions with the error:
I'm not sure why it would find these rasters on my machine but not in the checks because the rasters are created as a pytest Fixture in conftest.py by |
Co-authored-by: Anna Petrasova <[email protected]>
…o SeriesMap-redo
There is the same error for vectors... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still the bug in add_vectors and see Vashek's comment to create an issue about the code duplication.
SeriesMap creates a ipywidgets Slider for scrolling between a list of rasters and/or vectors.
SeriesMap creates a ipywidgets Slider for scrolling between a list of rasters and/or vectors.
A re-write of #2996 that is better: shorter code, a fewer bugs/ways to break it.