Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-1168] Metrics for total gas used for eth_call and total gas used for eth_estimateGas #335

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Jul 9, 2024

@cla-bot cla-bot bot added the s CLA signed label Jul 9, 2024
@amsanghi amsanghi changed the title Metrics for total gas used for eth_call and total gas used for eth_estimateGas [NIT-1168] Metrics for total gas used for eth_call and total gas used for eth_estimateGas Jul 9, 2024
@amsanghi amsanghi marked this pull request as ready for review July 9, 2024 15:04
internal/ethapi/api.go Outdated Show resolved Hide resolved
Tristan-Wilson
Tristan-Wilson previously approved these changes Jul 10, 2024
joshuacolvin0
joshuacolvin0 previously approved these changes Jul 10, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 64d5c61 into master Jul 12, 2024
6 checks passed
@joshuacolvin0 joshuacolvin0 deleted the metrics branch July 12, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants