Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-1168] Metrics for total gas used for eth_call and total gas used for eth_estimateGas #2478

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Jul 11, 2024

uses OffchainLabs/go-ethereum#335

Metrics added for total gas used for eth_call (rpc/gas_used/eth_call) and total gas used for eth_estimateGas (rpc/gas_used/eth_estimategas)

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 11, 2024
@amsanghi amsanghi marked this pull request as ready for review July 11, 2024 05:24
@amsanghi amsanghi changed the title Metrics for total gas used for eth_call and total gas used for eth_estimateGas [NIT-1168] Metrics for total gas used for eth_call and total gas used for eth_estimateGas Jul 11, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit b50b745 into master Jul 15, 2024
13 checks passed
@joshuacolvin0 joshuacolvin0 deleted the metrics branch July 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants