-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NIT-2554][Config Change] Test manual batch-poster fallback for DAS #2665
base: master
Are you sure you want to change the base?
Conversation
The batch-poster wasn't using the DAS because the max retention period wasn't being set correctly.
This test checks whether the batch-poster manual fallback for DAS works correctly. Here are the steps of the test: * Setup a L2 chain using a DAS * Sends a batch using the DAS * Shutdown the DAS * Fail to send a batch because the fallback is disabled * Enable the fallback * Verify the batch was sent with the fallback
ParentChainNodeURL: "none", | ||
RequestTimeout: 5 * time.Second, | ||
} | ||
config := das.DefaultDataAvailabilityConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is something where it would be nice if we could develop an internally-accepted style guide, but:
I really find the inline declaration of the struct more readable. The structure of the data easier to visualize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I'm not using a composite literal because I want to initialize all fields based on the default config. The default config had changed, and the DAS tests were not using the correct config because of that.
Rename --node.batch-poster.disable-dap-fallback-store-data-on-chain to --node.batch-poster.enable-dap-fallback-store-data-on-chain
…-poster-das-fallback' into gligneul/test-batch-poster-das-fallback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This test checks whether the batch-poster manual fallback for DAS works
correctly. Here are the steps of the test:
Close NIT-2557
Config Change
Rename
node.batch-poster.disable-dap-fallback-store-data-on-chain
tonode.batch-poster.enable-dap-fallback-store-data-on-chain