-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NIT-2554][Config Change] Test manual batch-poster fallback for DAS #2665
Open
gligneul
wants to merge
16
commits into
master
Choose a base branch
from
gligneul/test-batch-poster-das-fallback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+115
−41
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5f5d9c8
Fix DAS test by setting the default config
gligneul 9190038
Test manual batch-poster fallback for DAS
gligneul beca92d
Check for context-deadline exceeded error
gligneul d89d31e
Merge branch 'master' into gligneul/test-batch-poster-das-fallback
gligneul 7f0068c
Merge branch 'master' into gligneul/test-batch-poster-das-fallback
gligneul f0f5af5
Use positive in config name (disable -> enable)
gligneul a03219d
Merge branch 'master' into gligneul/test-batch-poster-das-fallback
gligneul 143c68b
Enable DAP fallback on test config
gligneul 50a90f6
Merge remote-tracking branch 'refs/remotes/origin/gligneul/test-batch…
gligneul 1afc2ce
Merge branch 'master' into gligneul/test-batch-poster-das-fallback
gligneul c1209e8
Merge branch 'master' into gligneul/test-batch-poster-das-fallback
gligneul 75a3077
Merge branch 'master' into gligneul/test-batch-poster-das-fallback
gligneul 61d1c7e
Merge branch 'master' into gligneul/test-batch-poster-das-fallback
gligneul 23d7758
Merge branch 'master' into gligneul/test-batch-poster-das-fallback
gligneul 174056e
Merge branch 'master' into gligneul/test-batch-poster-das-fallback
gligneul 7937e63
Merge branch 'master' into gligneul/test-batch-poster-das-fallback
gligneul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is something where it would be nice if we could develop an internally-accepted style guide, but:
I really find the inline declaration of the struct more readable. The structure of the data easier to visualize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I'm not using a composite literal because I want to initialize all fields based on the default config. The default config had changed, and the DAS tests were not using the correct config because of that.