-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MMR custom music support to OOTR. .OOTRS file improvements #2044
Conversation
I'll squash before marking this as ready 😅 |
So I'm thinking that this is ready to merge after resolving CI checks + conflicts. A handful of folks have used it on my branch without issues. There are a few things that may be broken but I wouldn't consider them a show-stopper for merging this but wanted to get your thoughts:
|
With the last commit this should remain compatible with the new web patcher. Obviously the web patcher won't support the MMR music, but this shouldn't break Dev once it's merged. |
…are we even trying to support this garbage
@owlisnotacat1 would you be willing to give this a code review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I couldn't find any errors and I've been regularly playing on this branch. 👍
Sorry about the late response I've been swamped with stuff recently |
No worries, thank you for the review! |
This PR adds the ability to import MMR's custom music directly into OOTR.
Also updates how custom instruments get added into the .ootrs meta files while remaining backwards compatible with the current format.
As far as I know this is working but I'm not as good at testing this stuff as @owl_is_not_a_cat