Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable flake8 checks in github actions (lint) #24

Closed
wants to merge 1 commit into from
Closed

Enable flake8 checks in github actions (lint) #24

wants to merge 1 commit into from

Conversation

soxofaan
Copy link
Member

@soxofaan soxofaan commented Jan 22, 2024 •
edited
Loading

Issue #16: flake8 checks

@soxofaan soxofaan mentioned this pull request Jan 22, 2024
Closed
@soxofaan soxofaan changed the title Issue #16 enable flake8 checks Enable flake8 checks in github actions (lint) Jan 22, 2024
@soxofaan
Copy link
Member Author

needs some flake8 config, but unfortunately this can't be done through pyproject.toml yet, but other file that pollutes the project root.
Alternatively, we could also just go for ruff (https://docs.astral.sh/ruff/) instead of flake8, which is the new hot thing nowadays

@soxofaan soxofaan mentioned this pull request Jan 22, 2024
Merged
@soxofaan
Copy link
Member Author

overruled by #25

@soxofaan soxofaan closed this Jan 22, 2024
@soxofaan soxofaan deleted the issue16-flake8 branch February 1, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soxofaan