Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Maptext #2108

Merged
merged 21 commits into from
Jan 19, 2025

Merge branch 'master' into muthafuckinmaptext

78fafe2
Select commit
Loading
Failed to load commit list.
Merged

Basic Maptext #2108

Merge branch 'master' into muthafuckinmaptext
78fafe2
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / InspectCode succeeded Jan 8, 2025 in 6s

9 new alerts

New alerts in code changed by this pull request

  • 8 warnings
  • 1 note

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 328 in OpenDreamClient/Rendering/DreamIcon.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant condition check before assignments Warning

Redundant check before assignment

Check notice on line 44 in OpenDreamClient/Rendering/DreamViewOverlay.cs

See this annotation in the file changed.

Code scanning / InspectCode

Prefer using concrete value over 'default' or 'new()' Note

Use 'null' instead of 'default'

Check warning on line 240 in OpenDreamShared/Dream/ImmutableAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Non-readonly type member referenced in 'GetHashCode()' Warning

Non-readonly field referenced in 'GetHashCode()'

Check warning on line 241 in OpenDreamShared/Dream/ImmutableAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Non-readonly type member referenced in 'GetHashCode()' Warning

Non-readonly field referenced in 'GetHashCode()'

Check warning on line 242 in OpenDreamShared/Dream/ImmutableAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Non-readonly type member referenced in 'GetHashCode()' Warning

Non-readonly field referenced in 'GetHashCode()'

Check warning on line 671 in OpenDreamShared/Dream/ImmutableAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are redundant elsewhere Warning

Blank lines are redundant, expected maximum 1 instead of 2

Check warning on line 264 in OpenDreamShared/Dream/MutableAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Non-readonly type member referenced in 'GetHashCode()' Warning

Non-readonly field referenced in 'GetHashCode()'

Check warning on line 265 in OpenDreamShared/Dream/MutableAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Non-readonly type member referenced in 'GetHashCode()' Warning

Non-readonly field referenced in 'GetHashCode()'

Check warning on line 266 in OpenDreamShared/Dream/MutableAppearance.cs

See this annotation in the file changed.

Code scanning / InspectCode

Non-readonly type member referenced in 'GetHashCode()' Warning

Non-readonly field referenced in 'GetHashCode()'