-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update node to latest LTS & other packages #919
Conversation
Also does npm
Trying to build this gives me a build fail. I think the only reason the git build is passing is that, as per the comment, the git workflow in build.yml was not updated.
Deleting the OED container and trying to rebuild also failed, so I think that just changing the node dependency breaks quite a bit. |
Hi @spearec. Did you delete both the container and the image? If I recall correctly, you will see the build create the new node version after that. I realize now that my comment in the limitation was not completely clear. Let me know and I'll look into this if needed. |
- bumps typescript, react, react-dom, react-intl, react-redux, react-select, and their types files to the latest version - as far as I can tell I've also fixed any breaking migration issues
I believe I have properly installed Node LTS on my fork. The issue seemed to be related to having outdated react and typescript packages, causing conflicting dependencies. |
- react-notification system has not been update in 3 years and does not support react 18 - react-toastify is a much newer and simpler package - notifications state has been removed, as toastify comes with a system for dispatching notifications
has 3 TS errors
The non-hook react code is causing errors in some plotly container inclusions for missing values. These are suppressed for now.
- upgrade eslint and eslint-plugin-jsdoc to latest (minor update) - update @typescript-eslint/eslint-plugin to latest (major update) - add @types/node as devDependencies which upgraded most uses to latest (major update)
- minor update to node version to match OED one - patch for git directory ownership issue
@spearec was able to install but did see an issue with permissions in VSC. If anyone else sees this then please let us know. This is now ready to merge. |
Description
Another housekeeping PR that updates node and npm.
Thanks to @spearec for doing the work to figure out how to get rid of a number of issues and upgrade other packages. A substantial part of the work in this PR is due to @spearec. This upgraded React/Redux packages and TypeScript along with needed code changes.
Updated eslint packages for new TypeScript version.
Workaround for GitHub actions issue with git permissions so checks/tests can run.
Fixes #990.
Type of change
Checklist
Limitations
Developers will need to delete the web container/image to see this change.
Ignores TS errors for some older, non-hook components but they should go away soon.