Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node to latest LTS & other packages #919

Merged
merged 16 commits into from
Aug 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:

runs-on: ubuntu-latest
# Make sure the node version here matches containers/web/Dockerfile for the standard OED build.
container: node:16.13.2
container: node:18.17.1

services:
postgres:
Expand Down Expand Up @@ -58,6 +58,14 @@ jobs:
chmod 777 src/server/tmp
chmod 777 src/server/tmp/uploads

# This is a hack/fix from https://github.com/actions/runner/issues/2033 that (hopefully) fixes
# fatal: detected dubious ownership in repository at '/__w/OED/OED'
# Other refs: https://github.com/crytic/slither-action/pull/50, https://github.com/actions/checkout/issues/1169,
# https://github.com/actions/checkout/issues/1048
# TODO Remove once final fix is in for GitHub workflows.
- name: make git permissions ok
run: chown -R $(id -u):$(id -g) $PWD

- name: Install dependencies
run: npm ci

Expand Down
2 changes: 1 addition & 1 deletion containers/web/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

# Dockerfile for NodeJS application portion
# Make sure the node version here matches .github/workflows/build.yml for the GitHub workflow.
FROM node:16.13.2
FROM node:18.17.1

# Create the directory for the app
RUN mkdir -p "/usr/src/app"
Expand Down
5 changes: 0 additions & 5 deletions desc.d.ts

This file was deleted.

Loading